Optional no shadow root. Fix attribute marshalling on pages with full Polymer. Add querySelector shortcut.#1
Open
patternseek wants to merge 3 commits intoComponentKitchen:masterfrom
Open
Conversation
…oot' attribute on the template.
…atter breaks if another component on the page use using full fat Polymer.
…e with non-shadow rooted components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
These are the minor changes discussed via email. They allow creation of a component with no shadow root and add a helper member to use as an alternative to "this.$" in that situation. Also there's a fix for attribute marshalling breaking on pages that have components which use full Polymer.
Sorry they're all in one PR, my Github-foo is weak. The changes are pretty tiny though. Let me know if you want me to go back and split it up.
Cheers,
Tolan.